fix(caches/in-memory): allow explicit in-memory caches #26807
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What about just not logging when the raw error kind is a readonly file system? That would mean people wouldn't have to discover this flag to supress the warnings. By the way, I'm not sure about a CLI flag for this. Maybe it should be an env var so all sub commands share the behaviour. |
dsherret
requested changes
Nov 13, 2024
|
It looks like https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.ReadOnlyFilesystem was stabilized in Rust 1.83 We'll upgrade the repo to 1.83 soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the verbose warnings of: #26747
Some users (such as me) don't have access to a writeable file system.
In those cases it would be nice to have a global flag to run deno with in-memory caches only.
The code for falling back to in-memory caches is already there but no way to use it without beeing spammed with concerning error messages.
I could need some help here because i didn't figure out how to properly register the cli flag.